Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: add mop upsert API #774

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

INTERNAL: add mop upsert API #774

wants to merge 1 commit into from
+166 −0

Conversation

oliviarla
Copy link
Collaborator

@oliviarla oliviarla commented Jul 4, 2024 •
edited
Loading

@oliviarla oliviarla marked this pull request as draft July 5, 2024 02:05
@jhpark816
Copy link
Collaborator

@oliviarla
이제 PR 정식으로 보내주시죠.

@oliviarla oliviarla marked this pull request as ready for review July 11, 2024 07:21
@jhpark816
Copy link
Collaborator

@brido4125 리뷰 바랍니다.

brido4125
brido4125 requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@brido4125 brido4125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectionOperationImple 클래스의 생성자에서
setAPIType을 설정하는 로직이 빠진것 같아요
추가해주셔야할 것 같습니다.

src/main/java/net/spy/memcached/collection/MapUpsert.java Show resolved Hide resolved
src/test/manual/net/spy/memcached/collection/map/MopUpsertTest.java Show resolved Hide resolved
@oliviarla
Copy link
Collaborator Author

@brido4125 리뷰 반영했습니다.

@jhpark816 jhpark816 requested review from hjyun328 and uhm0311 and removed request for jhpark816 and hjyun328 July 17, 2024 11:23
@jhpark816
Copy link
Collaborator

@uhm0311 추가 리뷰어 지정합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brido4125 brido4125 brido4125 approved these changes

@uhm0311 uhm0311 Awaiting requested review from uhm0311

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviarla @jhpark816 @brido4125