Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Remove unused TimeoutException constructors. #779

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

uhm0311
Copy link
Collaborator

@uhm0311 uhm0311 commented Jul 9, 2024

πŸ”— Related Issue

⌨️ What I did

  • OperationTimeout, CheckedOperationTimeout 클래슀의 μƒμ„±μž 쀑 μ‚¬μš©ν•˜μ§€ μ•ŠλŠ” μƒμ„±μžλ₯Ό μ œκ±°ν•©λ‹ˆλ‹€.
  • μƒμ„±μžλ₯Ό μ œκ±°ν•˜λ©΄μ„œ ν•„μš”ν•œ 변경도 ν•¨κ»˜ λ°˜μ˜ν•©λ‹ˆλ‹€.

Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œ

private static boolean isBulkOperation(Operation op, Collection<Operation> ops) {
if (op instanceof StoreOperation || op instanceof DeleteOperation) {
return ops.size() > 1;
if (firstOp != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ–΄λ–€ 연산을 μˆ˜ν–‰ν•  λ•Œ timeout λ°œμƒν•  수 μžˆλŠ” κ²ƒμ΄λ―€λ‘œ,
opsλŠ” nullμ΄λ‚˜ emptyκ°€ μ•„λ‹ˆλ„λ‘ κ°•μ œν™”ν•˜λ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

@jhpark816
Copy link
Collaborator

@oliviarla @brido4125 리뷰 λ°”λžλ‹ˆλ‹€.

@jhpark816 jhpark816 merged commit 6e0aa52 into naver:develop Jul 10, 2024
3 checks passed
@uhm0311 uhm0311 deleted the uhm0311/develop7 branch July 11, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants