fix(type): filter nullish data

Filter nullish data to exclude from rendering Fix #2020
naver · Mar 30, 2021 · 857bbca · 857bbca
1 parent 48e4f56
commit 857bbca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/ChartInternal/internals/type.ts b/src/ChartInternal/internals/type.ts
@@ -2,7 +2,7 @@
  * Copyright (c) 2017 ~ present NAVER Corp.
  * billboard.js project is licensed under the MIT license
  */
-import {isString, isArray} from "../../module/util";
+import {isArray, isNumber, isString} from "../../module/util";
 import {TYPE, TYPE_BY_CATEGORY} from "../../config/const";
 
 export default {
@@ -236,7 +236,7 @@ export default {
 			this.isScatterType(d) ||
 			this.isBubbleType(d) ||
 			this.isCandlestickType(d) ||
-			this.isRadarType(d) ? d.values : [];
+			this.isRadarType(d) ? d.values.filter(v => isNumber(v.value) || Boolean(v.value)) : [];
 	},
 
 	barLineBubbleData(d) {

diff --git a/test/internals/data-spec.ts b/test/internals/data-spec.ts
@@ -24,7 +24,7 @@ describe("DATA", () => {
 			delta = {x: delta, y: delta};
 		}
 
-		return function(d, i) {
+		return function(d, i) {			
 			const node = d3Select(this);
 
 			expect(+node.attr(`${prefix}x`)).to.be.closeTo(x[i], delta.x);
@@ -90,7 +90,7 @@ describe("DATA", () => {
 
 		it("should draw correctly", () => {
 			const expectedCx = {443: [98, 294, 490], 995: [98, 294, 490]};
-			const expectedCy = {443: [194, 351, 36], 995: [391, 430, 351]};
+			const expectedCy = {443: [194, 351, 36], 995: [391, 0, 351]};
 			const main = chart.$.main;
 
 			main.selectAll(`.${CLASS.circles}-443 .${CLASS.circle}`)
@@ -153,10 +153,10 @@ describe("DATA", () => {
 			const expectedCx = [98, 294, 490];
 			const expectedCy = {
 				443: [181, 326, 36],
-				995: [362, 398, 326],
+				995: [362, 0, 326],
 				112: [354, 347, 340],
 				223: [391, 383, 376],
-				334: [376, 398, 362],
+				334: [376, 0, 362],
 				556: [326, 253, 181],
 				"778.889": [347, 376, 340]
 			};