bug(arc): label threshold not working properly for Pie and Donut

[michkami]

Description

By setting label_threshold for pie or donut it rerenders wrong texts after hiding columns.
As you can see in the example below (dame config as at the bottom of this issue), it shows 25.0% on data1, which shouldn't be there, as the threshold is set to 0.2 and data1's value is 10.

This is how it should look like:

It seems like changing this condition to:

const text = isUnderThreshold ?
	($$.getArcLabelFormat() || $$.defaultArcValueFormat)(value, ratio, id).toString() :
	"";

setTextValue(node, text, [-1, 1], hasGauge);

will fix the problem, as it will replace the text with value < threshold with an empty string.

Steps to check or reproduce

1. Open this chart
2. Use following code:

var chart = bb.generate({
  data: {
    columns: [
	["data1", 10],
	["data2", 30],
	["data3", 60]
    ],
    type: "pie"
  },
  pie: {
	label:{
		threshold: 0.2
	}
  },
  bindto: "#pieChart"
});

3. Hide data3.
4. Show data3

[netil]

@michkami, thanks for the report!
I'll check that.

[netil]

🎉 This issue has been resolved in version 1.12.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀