Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in Version 2.2.0 syntax error occurs in IE11 #1913

Closed
RonnyWeiss opened this issue Jan 29, 2021 · 6 comments
Closed

in Version 2.2.0 syntax error occurs in IE11 #1913

RonnyWeiss opened this issue Jan 29, 2021 · 6 comments
Labels

Comments

@RonnyWeiss
Copy link

Hello tried the ne version also in IE11 and syntax error occurs!

Would you please fix that?

Kind regards

Ronny

@michkami
Copy link
Collaborator

I updated to 2.2.0 in my local angular 8 project and had no syntax errors in IE11 yet.

@RonnyWeiss
Copy link
Author

I use this file:

https://naver.github.io/billboard.js/release/latest/dist/billboard.min.js

and got the error in ie can you please check that:

grafik

@RonnyWeiss
Copy link
Author

i just use an other file name :-)

@RonnyWeiss
Copy link
Author

in full file the error occurs in line 20,21
grafik

@netil netil added the bug label Feb 1, 2021
@netil
Copy link
Member

netil commented Feb 1, 2021

Hi @RonnyWeiss, the issue comes from Webpack v5, where webpack's runtime code uses ES2015 syntax.

After adding config option to transpile for older browser, looks working fine.
I'll be release the patch version soon.

netil added a commit to netil/billboard.js that referenced this issue Feb 1, 2021
As of Webpack v5 transpile using ES6 syntax, needs to
add extra target configuration to support old browser.

https://webpack.js.org/migrate/5/#need-to-support-an-older-browser-like-ie-11

Ref naver#1913
@netil netil closed this as completed in 594d18e Feb 1, 2021
github-actions bot pushed a commit that referenced this issue Feb 1, 2021
## [2.2.1](2.2.0...2.2.1) (2021-02-01)

### Bug Fixes

* **build:** suport for legacy browser ([594d18e](594d18e)), closes [/webpack.js.org/migrate/5/#need-to-support-an-older-browser-like-ie-11](https://github.com//webpack.js.org/migrate/5//issues/need-to-support-an-older-browser-like-ie-11) [#1913](#1913)
* **gauge:** units position if fullCircle ([62cd79e](62cd79e)), closes [#1914](#1914)
@RonnyWeiss
Copy link
Author

Thank you very much. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants