Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked tooltip can produce unnecessary recursive call #1979

Closed
netil opened this issue Mar 10, 2021 · 0 comments
Closed

Linked tooltip can produce unnecessary recursive call #1979

netil opened this issue Mar 10, 2021 · 0 comments
Assignees
Labels
Milestone

Comments

@netil
Copy link
Member

netil commented Mar 10, 2021

Description

When tooltip.linked options is used for several chart instances, can produce maximum call stack error.

This happens due to the event propagation among instances.

@netil netil added the bug label Mar 10, 2021
@netil netil added this to the Patch milestone Mar 10, 2021
@netil netil self-assigned this Mar 10, 2021
netil added a commit to netil/billboard.js that referenced this issue Mar 11, 2021
Prevent propagation among instances if isn't instantiated from the user's event

Ref naver#1979
@netil netil closed this as completed in b6af8ec Mar 11, 2021
github-actions bot pushed a commit that referenced this issue Mar 11, 2021
## [2.2.6](2.2.5...2.2.6) (2021-03-11)

### Bug Fixes

* **tooltip:** fix linked tooltip recursive call ([b6af8ec](b6af8ec)), closes [#1979](#1979)
github-actions bot pushed a commit that referenced this issue Mar 19, 2021
# [3.0.0-next.3](3.0.0-next.2...3.0.0-next.3) (2021-03-19)

### Bug Fixes

* **axis:** fix axis.x.max error throw ([de06361](de06361)), closes [#1981](#1981)
* **axis:** fix axis.x.tick.tooltip on rotated axis ([eed2f86](eed2f86)), closes [#1990](#1990)
* **axis:** remove x axis transition during resize ([a938681](a938681)), closes [#1949](#1949)
* **tooltip:** fix linked tooltip recursive call ([b6af8ec](b6af8ec)), closes [#1979](#1979)
* **zoom:** fix zoom on latest chrome ([37edc9b](37edc9b)), closes [/github.com/d3/d3-zoom/issues/231#issuecomment-802305692](https://github.com//github.com/d3/d3-zoom/issues/231/issues/issuecomment-802305692) [#1992](#1992)

### Features

* **api:** Enhance .export() option to specify size ([3c2de80](3c2de80)), closes [#815](#815) [#1969](#1969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment