Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in label names in data.labels.backgroundColors when spaces in label names (v3.1.0) #2160

Closed
tjohannto opened this issue Jun 25, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@tjohannto
Copy link

Description

when label names have spaces (like for country names etc) the created filter does have an inavalid url like url(#bb-1624614616765-labels-bg-data 11)

image

Steps to check or reproduce

https://jsfiddle.net/ujayzdfo/

@netil netil self-assigned this Jun 28, 2021
@netil netil added the bug label Jun 28, 2021
@netil netil added this to the Patch milestone Jun 28, 2021
@netil
Copy link
Member

netil commented Jun 28, 2021

Hi @tjohannto, thanks for the report. I'll be releasing patch for this.

netil added a commit to netil/billboard.js that referenced this issue Jun 28, 2021
Suffix data id value to handle spaced data ids.

Ref naver#2160
@netil netil closed this as completed in 4ffb654 Jun 28, 2021
github-actions bot pushed a commit that referenced this issue Jun 28, 2021
## [3.1.1](3.1.0...3.1.1) (2021-06-28)

### Bug Fixes

* **data:** Handle spaced data name for label bg color ([4ffb654](4ffb654)), closes [#2160](#2160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants