Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph theme has black background in Firefox #3218

Closed
matwey opened this issue May 16, 2023 · 3 comments
Closed

graph theme has black background in Firefox #3218

matwey opened this issue May 16, 2023 · 3 comments

Comments

@matwey
Copy link

matwey commented May 16, 2023

Description

Hello, I am using billboard.js 3.8.1 with two different themes: default and graph. I've created a minimal reproducible example mentioned before. My Firefix version is 102.11.

When default theme is used the plot looks like the following:
изображение

When graph theme the plot looks like the following:
изображение

background.color is ignored in the latter case.

Steps to check or reproduce

The code snipped is the following:

var chart = bb.generate({
    data: {
      type: "line",
      columns: [],
    },
    background: {
        color: "white"
    },
    bindto: "#lineChart"
});

var values = [["x", "y"], [1, 2], [3, 4]];
chart.load({
    rows: values,
});
@netil netil added the question label May 17, 2023
@netil
Copy link
Member

netil commented May 17, 2023

Tested on Firefox 113.0.1 and it showing without issue.

image

@ramirezcgn
Copy link

ramirezcgn commented May 17, 2023

Hi, I'm having the same issue and I guess is related to this line of the code (the rect element doesn't have the "bb-event-rect" class):

state.rendered && $$.updateEventRect($el.eventRect, true);
(line 68)

// when initilazed with empty data and data loaded later, need to update eventRect
state.rendered && $$.updateEventRect($el.eventRect, true);

PS: Is not related to Firefox, I'm having the issue in Edge.

Regards

@netil
Copy link
Member

netil commented May 18, 2023

@ramirezcgn thanks for the comment.
Confirmed the issue and is the side effect caused by #3203

@netil netil closed this as completed in 9f5f538 May 18, 2023
netil pushed a commit that referenced this issue May 18, 2023
Fix the side effect caused by #3203.
Make sure to set proper class name for eventRect element.

Ref #3218
github-actions bot pushed a commit that referenced this issue May 18, 2023
## [3.8.2](3.8.1...3.8.2) (2023-05-18)

### Bug Fixes

* **api:** fix classname setting for  eventRect element ([0a2fbde](0a2fbde)), closes [#3203](#3203) [#3218](#3218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants