fix(point): Fix rendering error when point.focus.only=true is set #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix rendering error for bubble and scatter type Ref naver#3406
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Sep 8, 2023
Remove optional chaining as a possible prevention from the fix of naver#3407 Can be removed, as of conditional from event interaction will prevent it.
netil
added a commit
that referenced
this pull request
Sep 8, 2023
Remove optional chaining as a possible prevention from the fix of #3407 Can be removed, as of conditional from event interaction will prevent it.
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Oct 12, 2023
Fix side effect caused by naver#3407. Add prevention on call of .isPointFocusOnly() Ref naver#3456
This was referenced Oct 12, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
# [3.10.0](3.9.4...3.10.0) (2023-10-25) ### Bug Fixes * **api:** Fix to return indexed categories ([1209138](1209138)), closes [#3365](#3365) * **axis:** Fix axis.x.height=0 to be applied ([0c562c3](0c562c3)), closes [#3424](#3424) * **axis:** Fix x axis tick text overlap with legend ([796671f](796671f)), closes [#3485](#3485) * **bar:** Fix stacking bar position on multiple xs ([674bad1](674bad1)), closes [#3372](#3372) * **candlestick:** Fix rendering on rotated axis ([fe4c04b](fe4c04b)), closes [#3387](#3387) * **clip:** Fix x axis hide on title.bottom ([d00052c](d00052c)), closes [#3364](#3364) * **domain:** fix trimXDomain not trimming min ([bacc287](bacc287)), closes [#3420](#3420) * **labels:** Fix index argument for nullish value ([13d1077](13d1077)), closes [#3547](#3547) * **option:** Fix inconsistency of padding ([694aa34](694aa34)), closes [#3426](#3426) * **point:** Fix data.onclick not called when point.senstivity is radius ([83b0206](83b0206)), closes [#3466](#3466) * **point:** Fix pointFucusOnly check error ([f9b65ac](f9b65ac)), closes [#3407](#3407) [#3456](#3456) * **point:** Fix rendering error when point.focus.only=true is set ([787fd15](787fd15)), closes [#3406](#3406) * **shape:** Fix circleY() undefined error ([d245853](d245853)), closes [#3388](#3388) * **subchart, zoom:** Fix returning domain value ([321510b](321510b)), closes [#3347](#3347) * **subchart:** Fix handlebar position ([83ef6d0](83ef6d0)), closes [#3358](#3358) * **title:** fix title text center align ([b0fc214](b0fc214)), closes [#3363](#3363) * **tooltip:** Fix tooltip.format.value call ([2e88484](2e88484)), closes [#3371](#3371) * **tooltip:** Fix tootip display on tooltip.init ([52083bf](52083bf)), closes [#3369](#3369) * **tooltip:** Fix wrong .tooltip.show() on rotated axis ([9b90c81](9b90c81)), closes [#3476](#3476) * **tooltip:** Fix wrong tooltip position with padding option ([041e144](041e144)), closes [#3473](#3473) * **zoom:** Fix initial error empty data with zoom ([a94d09c](a94d09c)), closes [#3470](#3470) ### Features * **api:** Intent to ship subchart method ([ac9e229](ac9e229)), closes [#3342](#3342) * **plugin:** Add nullString option ([29bdb0c](29bdb0c)), closes [#3412](#3412) [#3413](#3413) * **point:** Intent to ship point.radialGradient ([7b51fd6](7b51fd6)), closes [#3405](#3405) * **regions:** Intent to ship regions.label ([0496ec6](0496ec6)), closes [#3319](#3319) * **theme:** Add new modern theme ([b0f1aa7](b0f1aa7)) * **tooltip:** Provide y position for tooltip position callback ([a793a2e](a793a2e)), closes [#3434](#3434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3406
Details
Fix rendering error for bubble and scatter type