Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip.show() doesn't work properly on rotated axis #3476

Closed
netil opened this issue Oct 23, 2023 · 0 comments
Closed

tooltip.show() doesn't work properly on rotated axis #3476

netil opened this issue Oct 23, 2023 · 0 comments
Assignees
Labels

Comments

@netil
Copy link
Member

netil commented Oct 23, 2023

Description

The call of .tooltip.show({x: index}), not work as expected and the index value not showing correctly.
Calling with .tooltip.show({x: 1}) will show the tooltip for index 0, not the index 1.

Steps to check or reproduce

const chart = bb.generate({
	data: {
		columns: [
			["data1", 30, 200, 100, 400, 150, 250],
			["data2", 130, 340, 200, 500, 250, 350]
		],
		type: "line"
	},
	axis: {
		rotated: true
	}
});

// doesn't show any tooltip
chart.tooltip.show({x:0});

// show tooltip, but the tooltip is displaying x:0, not the x:1.
chart.tooltip.show({x:1});
@netil netil added the bug label Oct 23, 2023
@netil netil self-assigned this Oct 23, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Oct 23, 2023
- Adjust y coordinate for event on rotated axis
- Update d3's format specifier doc link

Ref naver#3476
@netil netil closed this as completed in 9b90c81 Oct 23, 2023
github-actions bot pushed a commit that referenced this issue Oct 23, 2023
# [3.10.0-next.6](3.10.0-next.5...3.10.0-next.6) (2023-10-23)

### Bug Fixes

* **point:** Fix data.onclick not called when point.senstivity is radius ([83b0206](83b0206)), closes [#3466](#3466)
* **tooltip:** Fix wrong .tooltip.show() on rotated axis ([9b90c81](9b90c81)), closes [#3476](#3476)
* **tooltip:** Fix wrong tooltip position with padding option ([041e144](041e144)), closes [#3473](#3473)
* **zoom:** Fix initial error empty data with zoom ([a94d09c](a94d09c)), closes [#3470](#3470)

### Features

* **theme:** Add new modern theme ([b0f1aa7](b0f1aa7))
github-actions bot pushed a commit that referenced this issue Oct 25, 2023
# [3.10.0](3.9.4...3.10.0) (2023-10-25)

### Bug Fixes

* **api:** Fix to return indexed categories ([1209138](1209138)), closes [#3365](#3365)
* **axis:** Fix axis.x.height=0 to be applied ([0c562c3](0c562c3)), closes [#3424](#3424)
* **axis:** Fix x axis tick text overlap with legend ([796671f](796671f)), closes [#3485](#3485)
* **bar:** Fix stacking bar position on multiple xs ([674bad1](674bad1)), closes [#3372](#3372)
* **candlestick:** Fix rendering on rotated axis ([fe4c04b](fe4c04b)), closes [#3387](#3387)
* **clip:** Fix x axis hide on title.bottom ([d00052c](d00052c)), closes [#3364](#3364)
* **domain:** fix trimXDomain not trimming min ([bacc287](bacc287)), closes [#3420](#3420)
* **labels:** Fix index argument for nullish value ([13d1077](13d1077)), closes [#3547](#3547)
* **option:** Fix inconsistency of padding ([694aa34](694aa34)), closes [#3426](#3426)
* **point:** Fix data.onclick not called when point.senstivity is radius ([83b0206](83b0206)), closes [#3466](#3466)
* **point:** Fix pointFucusOnly check error ([f9b65ac](f9b65ac)), closes [#3407](#3407) [#3456](#3456)
* **point:** Fix rendering error when point.focus.only=true is set ([787fd15](787fd15)), closes [#3406](#3406)
* **shape:** Fix circleY() undefined error ([d245853](d245853)), closes [#3388](#3388)
* **subchart, zoom:** Fix returning domain value ([321510b](321510b)), closes [#3347](#3347)
* **subchart:** Fix handlebar position ([83ef6d0](83ef6d0)), closes [#3358](#3358)
* **title:** fix title text center align ([b0fc214](b0fc214)), closes [#3363](#3363)
* **tooltip:** Fix tooltip.format.value call ([2e88484](2e88484)), closes [#3371](#3371)
* **tooltip:** Fix tootip display on tooltip.init ([52083bf](52083bf)), closes [#3369](#3369)
* **tooltip:** Fix wrong .tooltip.show() on rotated axis ([9b90c81](9b90c81)), closes [#3476](#3476)
* **tooltip:** Fix wrong tooltip position with padding option ([041e144](041e144)), closes [#3473](#3473)
* **zoom:** Fix initial error empty data with zoom ([a94d09c](a94d09c)), closes [#3470](#3470)

### Features

* **api:** Intent to ship subchart method ([ac9e229](ac9e229)), closes [#3342](#3342)
* **plugin:** Add nullString option ([29bdb0c](29bdb0c)), closes [#3412](#3412) [#3413](#3413)
* **point:** Intent to ship point.radialGradient ([7b51fd6](7b51fd6)), closes [#3405](#3405)
* **regions:** Intent to ship regions.label ([0496ec6](0496ec6)), closes [#3319](#3319)
* **theme:** Add new modern theme ([b0f1aa7](b0f1aa7))
* **tooltip:** Provide y position for tooltip position callback ([a793a2e](a793a2e)), closes [#3434](#3434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant