About domain in clip-path
#3684
Assignees
Labels
Comments
|
@m-gallesio, thanks for the suggestion. The full domain is used to not break any compatibility issues which stayed from the c3.js codebase. Aside of IE9 conditional and based on the
|
netil
pushed a commit
to netil/billboard.js
that referenced
this issue
Mar 13, 2024
Remove ie9 conditional and make setting clip-path's url() value to specify id value without setting full domain Ref naver#3684
github-actions bot
pushed a commit
that referenced
this issue
Mar 18, 2024
## [3.11.3](3.11.2...3.11.3) (2024-03-18) ### Bug Fixes * **clip:** Remove setting full domain url ([83bbd10](83bbd10)), closes [#3684](#3684) * **legend:** Fix legend title to show data.names if set ([e8fa131](e8fa131)), closes [#3662](#3662) * **tooltip:** Fix tooltip y coordinate with arc.rangeText ([d28258e](d28258e)), closes [#3673](#3673)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed
clip-paths generated by billboard.js use the current domain of the page.This is not a problem when viewing the chart or using the native billboard.js export, but can cause problems with areas / regions if other ways to export the chart to an image are used (we use this):
This is the code which creates
clip-pathattributes:https://github.com/naver/billboard.js/blob/master/src/ChartInternal/internals/clip.ts#L36
It references IE9 (way out of support) in which case the domain is skipped, and dates back to C3:
https://github.com/c3js/c3/blob/master/src/clip.ts#L5
The domain is explicitly stripped when using the native billboard.js export:
https://github.com/naver/billboard.js/blob/master/src/Chart/api/export.ts#L89
Of course we can handle this case ourselves (which I plan to do), but at this point I wonder if using the full domain serves any purpose (maybe disambiguation, which is pointless if it gets removed), and if not whether it can be directly skipped in all cases.
The text was updated successfully, but these errors were encountered: