Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc.needle.value is missing from typings #3697

Closed
m-gallesio opened this issue Mar 18, 2024 · 1 comment · May be fixed by gti-sos/SOS2324-21#87
Closed

arc.needle.value is missing from typings #3697

m-gallesio opened this issue Mar 18, 2024 · 1 comment · May be fixed by gti-sos/SOS2324-21#87
Assignees
@netil
Labels
type.d Type definition related

Comments

@m-gallesio
Copy link

As of version 3.11.3, the typings for gauge charts are missing the arc.needle.value property.
It does work as seen in the officiale example at https://naver.github.io/billboard.js/demo/#GaugeChartOptions.GaugeNeedle, so it's just a typing issue.
@netil netil added the type.d Type definition related label Mar 18, 2024
@netil
Copy link
Member

netil commented Mar 18, 2024

@m-gallesio, thanks for the report!

netil pushed a commit to netil/billboard.js that referenced this issue Mar 18, 2024
fix(types): Add missing arc.needle.value
6d0bf33 
Add definition for arc.needle.value

Ref naver#3697
@netil netil mentioned this issue Mar 18, 2024
Merged
@netil netil self-assigned this Mar 18, 2024
@netil netil closed this as completed in e0a30fe Mar 18, 2024
github-actions bot pushed a commit that referenced this issue Apr 15, 2024
@semantic-release-bot
chore(release): 3.12.0-next.1 [skip ci]
df497a2 
# [3.12.0-next.1](3.11.3...3.12.0-next.1) (2024-04-15)

### Bug Fixes

* **api:** Fix to return indexed categories ([55c17c6](55c17c6)), closes [#3365](#3365)
* **bar:** Fix stacking bar position on multiple xs ([216da62](216da62)), closes [#3372](#3372)
* **candlestick:** Fix rendering on rotated axis ([17f5058](17f5058)), closes [#3387](#3387)
* **clip:** Fix x axis hide on title.bottom ([beec1bb](beec1bb)), closes [#3364](#3364)
* **option:** Fix inconsistency of padding ([0c1ce81](0c1ce81)), closes [#3426](#3426)
* **shape:** Fix circleY() undefined error ([f4ac3f1](f4ac3f1)), closes [#3388](#3388)
* **subchart, zoom:** Fix returning domain value ([90338ec](90338ec)), closes [#3347](#3347)
* **subchart:** Fix handlebar position ([b897cbb](b897cbb)), closes [#3358](#3358)
* **title:** fix title text center align ([b254a61](b254a61)), closes [#3363](#3363)
* **tooltip:** Fix tooltip.format.value call ([f7d587d](f7d587d)), closes [#3371](#3371)
* **tooltip:** Fix tootip display on tooltip.init ([98e6f8b](98e6f8b)), closes [#3369](#3369)
* **types:** Add missing arc.needle.value ([e0a30fe](e0a30fe)), closes [#3697](#3697)
* **types:** Add missing region.label option ([e03057c](e03057c)), closes [#3732](#3732)

### Features

* **api:** Intent to ship subchart method ([976f04a](976f04a)), closes [#3342](#3342)
* **axis:** Intent to ship axis.tooltip ([54e77cb](54e77cb)), closes [#3603](#3603)
* **bundler:** Migrate babel -> esbuild ([ff0a98c](ff0a98c)), closes [#3601](#3601)
* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
* **regions:** Intent to ship regions.label ([b4e3bc2](b4e3bc2)), closes [#3319](#3319)
github-actions bot pushed a commit that referenced this issue May 27, 2024
@semantic-release-bot
chore(release): 3.12.0 [skip ci]
4b103b8 
# [3.12.0](3.11.3...3.12.0) (2024-05-27)

### Bug Fixes

* **api:** Fix scatter type loading ([413812d](413812d)), closes [#3740](#3740)
* **treemap:** Fix missing element arg on data.onover/out ([22428dc](22428dc)), closes [#3766](#3766)
* **types:** Add missing arc.needle.value ([e0a30fe](e0a30fe)), closes [#3697](#3697)
* **types:** Add missing region.label option ([e03057c](e03057c)), closes [#3732](#3732)
* **types:** Correct typo in BarOptions ([a0ad93a](a0ad93a)), closes [#3749](#3749)

### Features

* **axis:** Intent to ship axis.tooltip ([54e77cb](54e77cb)), closes [#3603](#3603)
* **axis:** Intent to ship axis.x.forceAsSingle ([6ad0554](6ad0554)), closes [#3764](#3764)
* **bundler:** Migrate babel -> esbuild ([ff0a98c](ff0a98c)), closes [#3601](#3601)
* **funnel:** Intent to ship funnel type ([e4cdda1](e4cdda1)), closes [#3449](#3449)
github-actions bot pushed a commit that referenced this issue May 27, 2024
@semantic-release-bot
chore(release): 3.12.0 [skip ci]
1da9699 
# [3.12.0](3.11.3...3.12.0) (2024-05-27)

### Bug Fixes

* **api:** Fix scatter type loading ([413812d](413812d)), closes [#3740](#3740)
* **treemap:** Fix generation w/non-exist node ([02987ab](02987ab)), closes [#3777](#3777)
* **treemap:** Fix missing element arg on data.onover/out ([22428dc](22428dc)), closes [#3766](#3766)
* **types:** Add missing arc.needle.value ([e0a30fe](e0a30fe)), closes [#3697](#3697)
* **types:** Add missing region.label option ([e03057c](e03057c)), closes [#3732](#3732)
* **types:** Correct typo in BarOptions ([a0ad93a](a0ad93a)), closes [#3749](#3749)
* **types:** Fix missing polar type ([7f5d5b0](7f5d5b0)), closes [#3778](#3778)

### Features

* **axis:** Intent to ship axis.tooltip ([54e77cb](54e77cb)), closes [#3603](#3603)
* **axis:** Intent to ship axis.x.forceAsSingle ([6ad0554](6ad0554)), closes [#3764](#3764)
* **bundler:** Migrate babel -> esbuild ([ff0a98c](ff0a98c)), closes [#3601](#3601)
* **funnel:** Intent to ship funnel type ([e4cdda1](e4cdda1)), closes [#3449](#3449)
@marrodcab12 marrodcab12 mentioned this issue Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
type.d Type definition related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade billboard.js from 3.11.3 to 3.12.1 gti-sos/SOS2324-21
2 participants
@netil @m-gallesio