Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): Fix data label y position when all data are 0 #1027

Merged
merged 1 commit into from Aug 14, 2019
Merged

fix(text): Fix data label y position when all data are 0 #1027

merged 1 commit into from Aug 14, 2019

Conversation

netil
Copy link
Member

@netil netil commented Aug 14, 2019

Issue

#1026

Details

  • Update the condition for y position when all data values are 0
  • add .getBoundingRect() to util, to cache element's .getBoundingClientRect() value

- Update the condition for y position when all data values are 0
- add .getBoundingRect() to util, to cache element's
.getBoundingClientRect() value

Ref #1026
@netil netil added the bug label Aug 14, 2019
@netil netil self-assigned this Aug 14, 2019
@netil netil merged commit 4b423a5 into naver:master Aug 14, 2019
@netil netil deleted the labels#1026 branch October 23, 2019 05:46
@netil
Copy link
Member Author

netil commented Nov 22, 2019

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@netil netil added the released label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant