Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): Fix wrong tooltip position with padding option #3475

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

netil
Copy link
Member

@netil netil commented Oct 23, 2023

Issue

#3473

Details

Reflect padding top/left option on tooltip positioning.

Reflect padding top/left option on tooltip positioning.

Ref naver#3473
@netil netil added the bug label Oct 23, 2023
@netil netil self-assigned this Oct 23, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.32% (-0.005%) from 94.325% when pulling 6f66aa7 on netil:padding#3473 into 157229f on naver:master.

@netil netil merged commit 041e144 into naver:master Oct 23, 2023
10 checks passed
@netil netil deleted the padding#3473 branch October 23, 2023 06:33
netil pushed a commit to netil/billboard.js that referenced this pull request Oct 26, 2023
Side effect caused by naver#3475.
The condition set where valid only for axis based chart

Ref naver#3473 (comment)
netil pushed a commit to netil/billboard.js that referenced this pull request Oct 26, 2023
Side effect caused by naver#3475.
The condition set where valid only for axis based chart

Ref naver#3473 (comment)
netil added a commit that referenced this pull request Oct 26, 2023
Side effect caused by #3475.
The condition set where valid only for axis based chart

Fix #3473 (comment)
github-actions bot pushed a commit that referenced this pull request Oct 26, 2023
## [3.10.1](3.10.0...3.10.1) (2023-10-26)

### Bug Fixes

* **tooltip:** Fix tooltip error on Arc type ([5e80d9d](5e80d9d)), closes [#3475](#3475) [/github.com//issues/3473#issuecomment-1781091685](https://github.com//github.com/naver/billboard.js/issues/3473/issues/issuecomment-1781091685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants