feat: add useAnimation option to WheelInput #189
Conversation
src/inputType/WheelInput.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * @typedef {Object} WheelInputOption The option object of the eg.Axes.WheelInput module | ||
| * @ko eg.Axes.WheelInput 모듈의 옵션 객체 | ||
| * @param {Number} [scale=1] Coordinate scale that a user can move<ko>사용자의 동작으로 이동하는 좌표의 배율</ko> | ||
| * @param {Number} [releaseDelay=300] Millisecond that trigger release event after last input<ko>마지막 입력 이후 release 이벤트가 트리거되기까지의 밀리초</ko> | ||
| * @param {Boolean} [useNormalized=true] Whether to calculate scroll speed the same in all browsers<ko>모든 브라우저에서 스크롤 속도를 동일하게 처리할지 여부</ko> | ||
| * @param {Boolean} [useAnimation=true] Whether to process coordinate changes through the mouse wheel as a continuous animation<ko>마우스 휠을 통한 좌표 변화를 연속적인 애니메이션으로 처리할지 여부</ko> |
There was a problem hiding this comment.
Magic mouse users should feel like a magic mouse, and a normal mouse should feel like a magic mouse.
This option will behave strangely for either a Magic Mouse user or a regular mouse.
src/inputType/PanInput.ts
Outdated
| @@ -338,6 +338,19 @@ export class PanInput implements InputType { | |||
| }); | |||
| } | |||
|
|
|||
| protected _getVector(properties: number[], direction: boolean[]): number[] { | |||
There was a problem hiding this comment.
I think while _applyScale shows what it actually does with its name (at least a part of it), _getVector does not reveal what's happening inside.
Why did you change its name like this?
There was a problem hiding this comment.
It was a function which applies direction and scale to the given offset and velocity.
It originally had the name getOffset, but the name was changed while calculating the velocity other than the offset.
Meanwhile, the class that inherits PanInput from view360 also overrides this. It don't just use scale and direction and use other calculations.
Instead of applyScale, I decided to name it getting a vector which meaning both velocity and offset.
We'll be using these names in RotationPanInput at view360 as well. Any good suggestions will be welcome.
There was a problem hiding this comment.
The name Vector is too general, I mean, vector of what is not included.
If you want to use the term vector, I would suggest getOffsetVector or something.
There was a problem hiding this comment.
The original name getOffset looks better than getOffsetVector.
But I'm little bit concerned about using this name for the velocity calculation as well.
There was a problem hiding this comment.
I think you can consider what would be better, and choose it yourself.
Just remember to choose self-representative names for it.
Details
As #174 is applied, WheelInput always uses an animation to smooth out coordinate movement through the mouse wheel.
However, there are use cases where playing smooth animation is unnecessary and the coordinate change needs to be applied immediately.
This provides an option whether to use animation for the coordinate change of WheelInput.