Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release to PanInput and RotatePanInput #195

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

malangfox
Copy link
Contributor

@malangfox malangfox commented Jul 29, 2022

Details

This adds a method release to stop and release the current input to PanInput and RotatePanInput.

Sometimes we need to cancel the current input that is occurring on a holdable InputType like PanInput .
For example, when using Flicking that includes PanInput, moveTo can occur while holding - (check this comment.)
release method can be used in cases like this.

Copy link
Member

@WoodNeck WoodNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malangfox malangfox merged commit e0e2e9b into naver:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants