Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix addEventListener options #209

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: fix addEventListener options #209

merged 1 commit into from
Dec 2, 2022

Conversation

daybrush
Copy link
Member

@daybrush daybrush commented Dec 1, 2022

Issue

#208

Details

malangfox
malangfox approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@malangfox malangfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It seems that indent is little broken, I'll check if the eslint settings are being applied incorrectly.

WoodNeck
WoodNeck approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@WoodNeck WoodNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't we add a test whether the event handler is removed correctly?

@daybrush
Copy link
Member Author

daybrush commented Dec 2, 2022

@WoodNeck

It seems difficult to write tests for IE.

@daybrush daybrush merged commit 5805c9d into naver:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malangfox malangfox malangfox approved these changes

@WoodNeck WoodNeck WoodNeck approved these changes

@ave10987 ave10987 Awaiting requested review from ave10987

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daybrush @malangfox @WoodNeck