Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add userSelect css props for non chrome browsers #210

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

malangfox
Copy link
Contributor

Details

This applies proper user-select styles for browsers that user-select: none is not available

@malangfox malangfox changed the title fix: add userSelect css props for non chrome browsers fix: add userSelect css props for non chrome browsers Dec 27, 2022
Copy link
Member

@WoodNeck WoodNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -75,6 +75,8 @@ export const TRANSFORM = (() => {
})();

export const PREVENT_DRAG_CSSPROPS = {
"-webkit-user-select": "none", /* Safari */
"-ms-user-select": "none", /* IE 10 and IE 11 */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is judged that there will be few users, but how about adding the -moz- prefix as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the old version of Firefox, adding user-select with -moz- prefix should be better.

Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malangfox malangfox merged commit 4c2156d into naver:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants