fix: add userSelect css props for non chrome browsers #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malangfox
changed the title
daybrush
reviewed
Dec 27, 2022
| @@ -75,6 +75,8 @@ export const TRANSFORM = (() => { | |||
| })(); | |||
|
|
|||
| export const PREVENT_DRAG_CSSPROPS = { | |||
| "-webkit-user-select": "none", /* Safari */ | |||
| "-ms-user-select": "none", /* IE 10 and IE 11 */ | |||
There was a problem hiding this comment.
It is judged that there will be few users, but how about adding the -moz- prefix as well?
There was a problem hiding this comment.
Considering the old version of Firefox, adding user-select with -moz- prefix should be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This applies proper user-select styles for browsers that
user-select: noneis not available