fix: trigger not handling all event handlers

[WoodNeck]

Issue

#52

Details

This fixes #52

[coveralls]

Coverage increased (+0.2%) to 93.985% when pulling 1f0011e on WoodNeck:fix-trigger-not-finished#52 into f39c2fd on naver:master.

[daybrush]

LGTM.

This method is executed even if the next handler is deleted.

However, if it check individually, it will cost a lot of checking.

[WoodNeck]

LGTM.

This method is executed even if the next handler is deleted.

However, if it check individually, it will cost a lot of checking.

This fix is for when the previous handler is removed.

The simplest representative code might look like the above screenshot,

[daybrush]

@WoodNeck

The example seems a little different.

const arr = [0, 1, 2];
const handlers = [...arr];

handlers.forEach(handler => {
   arr.splice(0, 1);
   console.log(handler);
});

[WoodNeck]

@daybrush
Of course that's different as I'm representing the previous code...

[daybrush]

@WoodNeck

You are right. The method you said is a good one because it doesn't get any errors.

What I'm talking about is a future problem. Events will continue to be triggered even after the event is released or destroyed.

[WoodNeck]

I'm fixing the issue of the handler removing itself here especially by calling once, and what you're saying is handlers removing each other.
I think that shouldn't happen, as that's highly dependent on the order of events attached.
And as we don't guarantee event order in any of our code, that's totally the user's fault doing that.
The user simply can bypass it by merging to handlers attached to the same event and conditionally handle them inside.
So IMO, event handlers shouldn't remove each other and it's okay to trigger events even if it's removed before calling them.

[mixed]

🥇