New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when the width is in percent, it doens't work well #113
Comments
Hi @hyoseon-kim, thanks for the detailed report. |
netil
added a commit
to netil/egjs-flicking
that referenced
this issue
Jul 10, 2018
netil
added a commit
to netil/egjs-flicking
that referenced
this issue
Jul 10, 2018
- Implement useTranslate - Change the panel's computation unit from integer to float Ref naver#113
netil
added a commit
to netil/egjs-flicking
that referenced
this issue
Jul 10, 2018
- Implement useTranslate - Change the panel's computation unit from integer to float Ref naver#113
The internal panel's dimension will be treated in float instead the integer. And will be added new
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When the upper element of flicking elements has width in percent, the width of each sub-panel is sometimes genreated in decimal point.
In this case, the image of the former flicking area doesn't go over well. so some part of the image remains like below example.
As you can see, the left side of that image remains. Follwing images will explain the reason.
When I try to flick to the left, that will be "translate(-734px, 0px)". but we expect "translate(-734.326px, 0px)". so we modified some of eg.js code, and it worked well.
return (parseFloat(val, 10) || 0) + (String(val).match(rx) || "px");
var coords = this._getDataByDirection([(this._conf.panel.size * i) + "px", 0]);
please review this corrections.
Steps to check or reproduce
The text was updated successfully, but these errors were encountered: