Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicking components with horizontal drag block vertical drag #673

Closed
gbyesiltas opened this issue May 16, 2022 · 13 comments
Closed

Flicking components with horizontal drag block vertical drag #673

gbyesiltas opened this issue May 16, 2022 · 13 comments
Assignees
Labels
🔖4.x v4.x~ related issue 🐛Bug Bugs

Comments

@gbyesiltas
Copy link

gbyesiltas commented May 16, 2022

Description

Flicking components with horizontal drag block vertical drag on mobile. I believe this happened after 4.6.3 or 4.7.0

Steps to check or reproduce

Go to the demo on the flicking website on mobile (or on a mobile viewport on the devtools) and try to drag vertically by starting your drag on the flicking component. It won't cause a vertical scroll.

@malangfox
Copy link
Contributor

Hello @gbyesiltas.
We have checked the inappropriate behavior you left behind.
This issue will be fixed in the next patch. We will notify you after the problem you reported is corrected.
Thank you for reporting!

@gbyesiltas
Copy link
Author

Hello @gbyesiltas.
We have checked the inappropriate behavior you left behind.
This issue will be fixed in the next patch. We will notify you after the problem you reported is corrected.
Thank you for reporting!

Thank you! :)

@WoodNeck WoodNeck added 🐛Bug Bugs 🔖4.x v4.x~ related issue labels May 18, 2022
@hyeon-9yu
Copy link

Is there a way to urgently modify it before applying the revised version?

@WoodNeck
Copy link
Member

@hyeon-9yu
I believe this happened after 4.7.0, so you can either:

  • use 4.6.x instead
npm i @egjs/flicking@~4.6.0
  • Add the following CSS to the .flicking-viewport element
.flicking-viewport {
  touch-action: pan-y !important;
}

Fix will be made after naver/egjs-axes#185

@hyeon-9yu
Copy link

hyeon-9yu commented May 19, 2022

@hyeon-9yu I believe this happened after 4.7.0, so you can either:

  • use 4.6.x instead
npm i @egjs/flicking@~4.6.0
  • Add the following CSS to the .flicking-viewport element
.flicking-viewport {
  touch-action: pan-y !important;
}

Fix will be made after naver/egjs-axes#185

@WoodNeck Thank you for help!
I've been using the 4.4.3 version of react-flicking since before, so I don't know why it's happening.
And I tried the method you provided, it works android chrome, but it seems that the same issue still occurs in IOS safari.

@WoodNeck
Copy link
Member

@hyeon-9yu
Did you try downgrading the version to 4.6.x?
If not, please try that way instead. We'll fix this asap in the next version :)

@malangfox
Copy link
Contributor

@gbyesiltas
We have released Flicking 4.7.1 that fixes this issue.
Try using version 4.7.1 and leave a message if you encounter any problems.

@gbyesiltas
Copy link
Author

@gbyesiltas
We have released Flicking 4.7.1 that fixes this issue.
Try using version 4.7.1 and leave a message if you encounter any problems.

Great, thank you :)

@limonte
Copy link

limonte commented May 23, 2022

4.7.1 doesn't work as well :/

@gbyesiltas
Copy link
Author

4.7.1 doesn't work as well :/

Hmm, 4.7.1 did work for me @limonte

@malangfox
Copy link
Contributor

malangfox commented May 24, 2022

4.7.1 doesn't work as well :/

Hmm, 4.7.1 did work for me @limonte

Can you check whether the touch-action css property of an element that uses horizontal flicking is automatically set to pan-y?
If you are using the ios Safari browser, this problem will be fixed in the next patch.

@limonte
Copy link

limonte commented May 25, 2022

v4.7.2, still doesn't work Safari on iPhone.

"Everyday 30 million people experience" isn't pleasant anymore. Are you testing this plugin on real devices before making releases?

@limonte
Copy link

limonte commented Jun 11, 2022

v4.9.0 works fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔖4.x v4.x~ related issue 🐛Bug Bugs
Projects
None yet
Development

No branches or pull requests

5 participants