Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use appropriate touch-action for element #675

Merged
merged 1 commit into from
May 20, 2022

Conversation

malangfox
Copy link
Contributor

Issue

#673

Details

It uses the 3.2.0 version of the Axes and sets appropriate touch-action according to the drag direction of Flicking.
For horizontal flicking, touch-action is set to pan-y. And for vertical flicking, touch-action is set to pan-x.

Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-22.03%) to 56.609% when pulling 060599e on malangfox:fix-pan-touch-action into 3c9958c on naver:master.

Copy link
Member

@WoodNeck WoodNeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malangfox malangfox merged commit 091f367 into naver:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants