Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .getTotalCount() from the code base #69

Closed
netil opened this issue Jan 11, 2018 · 0 comments
Closed

Remove .getTotalCount() from the code base #69

netil opened this issue Jan 11, 2018 · 0 comments
Assignees
@netil
Labels
🔖2.x v2.x~ related issue
Milestone
2.3.0

Comments

@netil
Copy link
Member

netil commented Jan 11, 2018

Description

.getTotalCount() was deprecated since 1.3.0.

According the deprecation process, the removal should happen at 4th release(It needed removed on 2.1.0).
@netil netil added the obsolete label Jan 11, 2018
@netil netil added this to the 2.2.0 milestone Jan 11, 2018
@netil netil self-assigned this Jan 11, 2018
netil added a commit to netil/egjs-flicking that referenced this issue Jan 12, 2018
@netil
refactor(Flicking): Remove .getTotalCount()
f042bcc 
Due to deprecation process

Ref naver#69
@netil netil mentioned this issue Jan 12, 2018
Merged
@netil netil closed this as completed in fd4c9b8 Jan 12, 2018
@WoodNeck WoodNeck added 🔖2.x v2.x~ related issue and removed 🔖2.x v2.x~ related issue labels Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
🔖2.x v2.x~ related issue
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@netil @WoodNeck