refactor: make classes for each move types #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoodNeck
added
🔖3.x
WoodNeck
force-pushed
the
refactor-move-type#189
branch
from
614e203
to
a9043ec
Compare
daybrush
reviewed
Apr 30, 2019
src/states/DraggingState.ts
Outdated
| const currentPanelPosition = currentPanel.getPosition(); | ||
| const currentPanelSize = currentPanel.getSize(); | ||
|
|
||
| let minimumDistanceToChange: number; |
There was a problem hiding this comment.
@WoodNeck
Couldn't parts related to minimumDistanceToChange also enter the MoveType class area?
There was a problem hiding this comment.
It could be done, but I also thought that the only changing part will be only for freeScroll move type, so I might be hesitated.
But I guess you're right. This might be included on MoveType I guess.
jongmoon
reviewed
May 2, 2019
| @@ -64,16 +65,36 @@ export interface FlickingOptions { | |||
| moveType: MoveTypeOption; | |||
| } | |||
|
|
|||
| export type MoveTypeObjectOption = MoveTypeSnapOption | MoveTypeFreeScrollOption; | |||
| export type MoveTypeStringOption = MoveTypeObjectOption["type"]; | |||
jongmoon
reviewed
May 2, 2019
| } = { | ||
| SNAP: "snap", | ||
| FREE_SCROLL: "freeScroll", | ||
| }; |
There was a problem hiding this comment.
By doing that, MOVE_TYPE.SNAP's type inference will be "snap", while string will be inferred if not.
jongmoon
approved these changes
May 2, 2019
WoodNeck
force-pushed
the
refactor-move-type#189
branch
from
9802137
to
6188b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#189, #190, #191
Details