refactor: declare methods in methods instead of created #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoodNeck
reviewed
Mar 20, 2023
There was a problem hiding this comment.
Have you been able to test this fix works in both our demo & Vite?
I remember that was defined like that because getCurrentInstance returned the wrong result when used in methods I guess.
I don't know if it was an issue with a specific version of Vue, but please at least test whether it works fine with the latest version of Vue.
daybrush
approved these changes
Mar 20, 2023
|
LGTM @malangfox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#770
Details
This changes
getPanelsandgetVirtualPanelsto be initialized inmethodsinstead ofcreated.In some cases, such a warning appears because the methods declared in
createdare not recognized.