fix: fix that element has loading image #3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixed
approved these changes
Nov 27, 2020
src/loaders/Loader.ts
Outdated
| public isReady = false; | ||
| public isPreReady = false; | ||
| public hasDataSize = false; | ||
| public hasLoading = false; |
There was a problem hiding this comment.
If you have changed it for testing, how about using getter?
test/unit/utils.ts
Outdated
| @@ -72,5 +72,6 @@ export function expectOrders(events: EventType[], values: string[]) { | |||
| // Then | |||
| const eventNames = events.map(e => e.eventType); | |||
|
|
|||
| console.log(eventNames); | |||
| @@ -8,13 +8,9 @@ import Loader from "./Loader"; | |||
|
|
|||
| export default class ImageLoader extends Loader<HTMLImageElement> { | |||
| public static EVENTS = ["load", "error"]; | |||
| public isPreReady() { | |||
There was a problem hiding this comment.
loader is a class that can only be used inside, this method is used internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3
Details