feat(react): support react component react-layout #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sculove
reviewed
Feb 13, 2018
packages/react-layout/src/Layout.js
Outdated
| } | ||
| updateChildren(children = this.props.children) { | ||
| let randomGroupKey = 0; | ||
| const itemChildren = (Array.isArray(children) ? children : [children]) |
There was a problem hiding this comment.
How about using 'React.Children.map' ?
sculove
reviewed
Feb 13, 2018
| @@ -0,0 +1,9 @@ | |||
| import Layout from "../Layout"; | |||
| import * as InfiniteGrid from "@egjs/infinitegrid"; | |||
There was a problem hiding this comment.
How about changing this code?
import Layout from "../Layout";
import InfiniteGrid, {GridLayout as GL} from "@egjs/infinitegrid";
import React from "react";
export default class GridLayout extends React.Component {
render() {
return <Layout {...this.props} type={GL}>{this.props.children}</Layout>
}
} 
daybrush
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#101
Details