Suggest that the 'setLayout' method supports Layout instance. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daybrush
force-pushed
the
JustifiedLayout#105
branch
from
31a24a0
to
ada9abe
Compare
sculove
reviewed
Feb 13, 2018
src/InfiniteGrid.js
Outdated
| @@ -161,7 +161,7 @@ class InfiniteGrid extends Component { | |||
| /** | |||
| * Specifies the Layout class to use. | |||
| * @ko 사용할 Layout 클래스를 지정한다. | |||
| * @param {Class} LayoutKlass The Layout class to use <ko>사용할 Layout 클래스</ko> | |||
| * @param {Class|eg.Layout} LayoutKlass The Layout class to use or an instance of a layout moudle<ko>사용할 Layout 클래스 또는 레이아웃 모듈의 인스턴스</ko> | |||
sculove
reviewed
Feb 13, 2018
src/layouts/JustifiedLayout.js
Outdated
| @@ -11,6 +11,8 @@ import {getStyleNames, assignOptions} from "../utils"; | |||
| * @param {Boolean} [options.horizontal=false] Direction of the scroll movement (false: vertical, true: horizontal) <ko>스크롤 이동 방향 (false: 세로방향, true: 가로방향)</ko> | |||
| * @param {Boolean} [options.minSize=0] Minimum size of item to be resized <ko> 아이템이 조정되는 최소 크기 </ko> | |||
| * @param {Boolean} [options.maxSize=0] Maximum size of item to be resized <ko> 아이템이 조정되는 최대 크기 </ko> | |||
| * @param {Boolean} [options.column=0] The number of items in a line <ko> 한 줄에 들어갈 수 있는 아이템의 개수 </ko> | |||
sculove
reviewed
Feb 13, 2018
| @@ -30,6 +32,7 @@ var layout = new eg.InfiniteGrid.JustifiedLayout({ | |||
| margin: 10, | |||
| minSize: 100, | |||
| maxSize: 300, | |||
| column: 5, | |||
| horizontal: true, | |||
There was a problem hiding this comment.
change interface.
remove maxColumn
column: 2
// or
column: [2, 10]
test/unit/InfiniteGrid.spec.js
Outdated
| @@ -90,6 +144,7 @@ describe("InfiniteGrid Test", function() { | |||
| // When (layout) | |||
| this.inst._renderer.container.innerHTML = items.join(""); | |||
| this.inst.layout(); | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#104 #105
Details