Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo(InfintiteGrid): provides tools to play the demos easily #116

Merged
merged 8 commits into from
Mar 23, 2018
Merged

demo(InfintiteGrid): provides tools to play the demos easily #116

merged 8 commits into from
Mar 23, 2018

Conversation

daybrush
Copy link
Member

Issue

#110

Details

@daybrush daybrush requested a review from mixed March 21, 2018 06:10
@coveralls
Copy link

coveralls commented Mar 21, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 82.98% when pulling 39e6f7f on younkue:master into 71c4617 on naver:master.

mixed
mixed reviewed Mar 22, 2018
View reviewed changes
Copy link
Member

@mixed mixed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed
mixed requested changes Mar 22, 2018
View reviewed changes
Copy link
Member

@mixed mixed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not support range slider of itemSize yet.
http://0.0.0.0:4000/assets/html/frame.html
http://0.0.0.0:4000/assets/html/frame2.html

@daybrush
Copy link
Member Author

if FrameLayout's itemSize is zero, it's auto size.
if it's not zero, itemSize becomes strange

mixed
mixed approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@mixed mixed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I got it. You`re right. Let's improve Framelayout demo next time.
I have made issue for it. #118

@mixed mixed merged commit fd1c69f into naver:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixed mixed mixed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daybrush @coveralls @mixed