feat(react-infinitegrid): add README and InfiniteGrid prototype #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongmoon
reviewed
Apr 6, 2018
| } | ||
| } | ||
|
|
||
| this._layout = new Klass({ |
There was a problem hiding this comment.
@Younkue It's not important thing. but It would be better to use meaningful name like Layout or LayoutType. First time I see, I confused Klass is what for?
daybrush
added a commit
to daybrush/egjs-infinitegrid
that referenced
this pull request
Apr 24, 2018
…r#134) * feat(react-infinitegrid): add README and InfiniteGrid module * fix(react-infinitegrid): fix README * fix(react-infinitegrid): fix variable naming
daybrush
added a commit
to daybrush/egjs-infinitegrid
that referenced
this pull request
May 14, 2018
…r#134) * feat(react-infinitegrid): add README and InfiniteGrid module * fix(react-infinitegrid): fix README * fix(react-infinitegrid): fix variable naming
daybrush
added a commit
to daybrush/egjs-infinitegrid
that referenced
this pull request
May 17, 2018
…r#134) * feat(react-infinitegrid): add README and InfiniteGrid module * fix(react-infinitegrid): fix README * fix(react-infinitegrid): fix variable naming
daybrush
added a commit
to daybrush/egjs-infinitegrid
that referenced
this pull request
May 29, 2018
…r#134) * feat(react-infinitegrid): add README and InfiniteGrid module * fix(react-infinitegrid): fix README * fix(react-infinitegrid): fix variable naming
daybrush
added a commit
that referenced
this pull request
May 29, 2018
* feat(react-infinitegrid): add README and InfiniteGrid prototype (#134) * feat(react-infinitegrid): add README and InfiniteGrid module * fix(react-infinitegrid): fix README * fix(react-infinitegrid): fix variable naming * feat(react-infinitegrid): use DOMRenderer, Watcher, ItemManger, Infinite * fix(react-infinitegrid): fix structure to infinitegrid * feat(react-infinitegrid): add recycle structure * fix(react-infinitegrid): fix structure to infinitegrid * feat(react-infinitegrid): add loadingBar * feat(react-infinitegrid): add isConstantSize props * feat(react-infinitegrid): add loading props * feat(react-infinitegrid): add types * fix(react-infinitegrid): fix loading and add componentWillUnmount * demo(react-infinitegrid): fix demo * fix(react-infinitegrid): fix types * fix(react-infinitegrid): fix prepend bug * fix(react-infinitegrid): update infinitegrid * fix(react-infinitegrid): fix README * fix(react-infinitegrid): fix data bug * fix(react-infinitegrid): fix no key bug * feat(react-infinitegrid): add getStatus and setStatus * test(react-infinitegrid): add karma test * fix(react-infinitegrid): fix data types * test(react-infinitegrid): test scroll * fix(react-infinitegrid): update groups * fix(react-infinitegrid): fix call requestappend multiple error * fix(react-infinitegrid): fix no update and babel * fix(react-infinitegrid): fix layout structure * test(react-infinitegrid): test layout method Close #128 Close #129 Close #148 Close #149 Close #150 Close #162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#128
#131
Details