Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PanoImageRenderer): Refactoring/tune renderer & add keepUpdate #94

Merged
merged 3 commits into from
Dec 22, 2017

Conversation

jongmoon
Copy link

Issue

#89

Details

  1. Shorten image load process (<-- It makes better performance)
  2. Add keepUpdate interface Add interface for controlling to keep update. #93
  3. Refactoring Code

WebGL Command is captured using [WebGL Inspector](http://benvanik.github.io/WebGL-Inspector/

  • refactoring-command
  • Remove useless code
    • (like !this.hasRenderingContext() check. because render function should be called after rendering context sucessfull)

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 40.776% when pulling 4d97bc2 on jongmoon:video#89 into 27f24d3 on naver:video#44.

Copy link
Contributor

@happyhj happyhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 45.754% when pulling 6330764 on jongmoon:video#89 into 27f24d3 on naver:video#44.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 45.67% when pulling 85419b8 on jongmoon:video#89 into 27f24d3 on naver:video#44.

@jongmoon jongmoon merged commit 1a1cbfb into naver:video#44 Dec 22, 2017
@jongmoon jongmoon deleted the video#89 branch January 16, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants