Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): enable travis-ci to test webgl #95

Merged
merged 30 commits into from
Dec 22, 2017
Merged

chore(all): enable travis-ci to test webgl #95

merged 30 commits into from
Dec 22, 2017

Conversation

happyhj
Copy link
Contributor

@happyhj happyhj commented Dec 21, 2017

Issue

#69

Details

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 44.948% when pulling f165856 on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 44.948% when pulling 7447519 on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.7%) to 39.329% when pulling 551ddb0 on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+11.2%) to 56.272% when pulling c21abd5 on render#69 into 36f74ae on master.

jongmoon
jongmoon suggested changes Dec 22, 2017
View reviewed changes
package.json Outdated
@@ -44,6 +44,8 @@
"webvr-polyfill": "^0.9.16"
},
"devDependencies": {
"karma-electron": "^5.2.2",
"electron": "^1.7.10",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happyhj How about to remove?

test/unit/YawPitchControl/TiltMotionInput.spec.js Outdated
@@ -52,7 +52,7 @@ describe("TiltMotionInput", function() {
deltaPitch = 0;
});

it("Delta pitch should stay near 0 when rotating yaw axis", () => {
it.skip("Delta pitch should stay near 0 when rotating yaw axis", () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happyhj Why skip?

@coveralls
Copy link

Coverage Status

Coverage increased (+11.2%) to 56.272% when pulling 7d40a9c on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+11.02%) to 56.054% when pulling 907b90e on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+17.03%) to 62.064% when pulling 907b90e on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+17.03%) to 62.064% when pulling bcfa014 on render#69 into 36f74ae on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+17.03%) to 62.064% when pulling 386d6d0 on render#69 into 36f74ae on master.

@jongmoon
Copy link

LGTM

@happyhj happyhj merged commit 9d10153 into master Dec 22, 2017
@jongmoon jongmoon deleted the render#69 branch December 26, 2017 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongmoon jongmoon jongmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@happyhj @coveralls @jongmoon