Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

fix: change event is not triggered on mobile devices #16

Merged
merged 3 commits into from
Nov 4, 2020
Merged

fix: change event is not triggered on mobile devices #16

merged 3 commits into from
Nov 4, 2020

Conversation

WoodNeck
Copy link
Member

@WoodNeck WoodNeck commented Nov 2, 2020

Issue

#15

Details

This fixes #15

@WoodNeck WoodNeck added the bug label Nov 2, 2020
@WoodNeck WoodNeck self-assigned this Nov 2, 2020
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@WoodNeck WoodNeck changed the title fix: change event is not triggered fix: change event is not triggered on mobile devices Nov 2, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 69.87% when pulling 2a06398 on WoodNeck:fix-no-change-event#15 into ee816bd on naver:master.

mixed
mixed approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@mixed mixed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daybrush
daybrush approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WoodNeck WoodNeck merged commit 8ddfe93 into naver:master Nov 4, 2020
@WoodNeck WoodNeck deleted the fix-no-change-event#15 branch November 4, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mixed mixed mixed approved these changes

@daybrush daybrush daybrush approved these changes

Assignees

@WoodNeck WoodNeck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"change" event is not triggered when element is at the page's very bottom
5 participants
@WoodNeck @CLAassistant @coveralls @mixed @daybrush