Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The index has already changed before 'beforeFlickStart' event is fired #219

Closed
sculove opened this issue May 18, 2016 · 0 comments
Closed

The index has already changed before 'beforeFlickStart' event is fired #219

sculove opened this issue May 18, 2016 · 0 comments
Labels
bug flicking

Comments

@sculove
Copy link
Contributor

sculove commented May 18, 2016

Description

eg.Flicking should change index after flickEne event.
netil added a commit to netil/egjs that referenced this issue May 23, 2016
@netil
fix(Flicking): Panel number have to change on 'flickEnd' event
260b773 
Changed to alter panel's index and no, to be only on _setPanelNo() method.
Added _getNumByDirection() to get pos/neg according direction
Added _revertPanelNo() in case of revert to previous position
Changed _triggerEvent() to pass previous index/no on non 'flickEnd' events

Ref naver#219
@netil netil mentioned this issue May 23, 2016
Closed
@netil netil closed this as completed in 3a79f6c May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug flicking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sculove