Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicking-Preview Padding - Wrapper width does not match with panel width #225

Closed
jongmoon opened this issue May 19, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@jongmoon
Copy link
Contributor

jongmoon commented May 19, 2016

Description

When previewPadding specified, Padding values are added on width of wrapper(#wrapper). But the padding values are subtracted from panel(.eg-flick-panel) width.

image

It makes padding area looks different from what we expected.

Steps to check or reproduce

#wrapper {
  width:300px;
  height:300px;
}
 $("#wrapper").flicking({
    previewPadding: [ 50, 50 ],
    defaultIndex: 3
 });

Result

image

Why

image

Expected

Remove Unexpected Area above.
So Wrapper width(current: 300px) should match with panel width(200px).

@jongmoon
Copy link
Contributor Author

jongmoon commented May 19, 2016

Related Code:

http://codepen.io/jongmoon/pen/XdLbpr

@netil netil self-assigned this May 31, 2016
@netil netil modified the milestone: 1.3.0 Jun 28, 2016
netil added a commit to netil/egjs that referenced this issue Jul 8, 2016
When previewPadding is given, set wrapper element's width/height as panel's size.

Ref naver#225
@netil netil closed this as completed in 05bbcf4 Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants