Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cache location object #233

Closed
happyhj opened this issue May 26, 2016 · 0 comments
Closed

Don't cache location object #233

happyhj opened this issue May 26, 2016 · 0 comments
Assignees
@happyhj
Labels
bug persist
Milestone
1.2.0

Comments

@happyhj
Copy link
Contributor

happyhj commented May 26, 2016 •
edited

Description

On IE8, caching location object can cause script error.
To avoid this, should use it directly from global object.
@happyhj happyhj added this to the 1.2.0 milestone May 26, 2016
@happyhj happyhj self-assigned this May 26, 2016
happyhj added a commit to happyhj/egjs that referenced this issue May 26, 2016
@happyhj
fix(persist): add IE8 exception handling
821d405 
replace cached location with global.location
Add try catch block on storage.getItem() in isStorageAvailable method

ref naver#233
ref naver#234
@happyhj happyhj mentioned this issue May 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@happyhj happyhj

Labels
bug persist
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@happyhj