Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.restore() method not working #243

Closed
netil opened this issue Jun 3, 2016 · 0 comments
Closed

.restore() method not working #243

netil opened this issue Jun 3, 2016 · 0 comments
Assignees
@netil
Labels
bug flicking
Milestone
1.2.0

Comments

@netil
Copy link
Member

netil commented Jun 3, 2016

Description

When panel is positioned in right position, but not matching with the index

Steps to check or reproduce

    1. Panel is positioned in right position, but not matching with the index
    • ex) panel moved to next panel and positioned in exact position like normal move
    1. Event stopped on 'beforeFlickStart' event.
    1. .restore() is not working
@netil netil added the bug label Jun 3, 2016
@netil netil added this to the 1.2.0 milestone Jun 3, 2016
@netil netil self-assigned this Jun 3, 2016
@netil netil added the flicking label Jun 3, 2016
jongmoon pushed a commit to jongmoon/egjs that referenced this issue Jun 8, 2016
fix(flicking): .restore() condition update
72d6b11 
fix(flicking): .restore() condition update

.restore() not working when panel is positioned in right position, but not matching with the index.
Updated to check index value for the right position instead of the panel's position.

Ref naver#243
@netil netil closed this as completed Jun 9, 2016
jongmoon pushed a commit that referenced this issue Jun 10, 2016
fix(flicking): .restore() condition update
a3667f5 
fix(flicking): .restore() condition update

.restore() not working when panel is positioned in right position, but not matching with the index.
Updated to check index value for the right position instead of the panel's position.

Ref #243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug flicking
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@netil