Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MovableCoord - release bug #288

Closed
jongmoon opened this issue Jul 12, 2016 · 0 comments
Closed

MovableCoord - release bug #288

jongmoon opened this issue Jul 12, 2016 · 0 comments
Assignees
@jongmoon
Labels
bug movableCoord
Milestone
1.3.0

Comments

@jongmoon
Copy link
Contributor

jongmoon commented Jul 12, 2016 •
edited

Description

When moved differently from setting direction(eg. MC.DIRECTION_VERTICAL, MC.DIRECTION_HORIZONTAL), MovableCoord does not fire 'release' event when touch ends.

Important thing we should notice is that
it loses chance to setInterrupt(false) by skipping 'release' process.

It makes side effects on non-interruptable component like flicking

When user flicks on different direction, its prevented status remain true
It makes flicking component interruptable although it is set interruptable: false;

Steps to check or reproduce

  1. set MovableCoord with HORIZONTAL_DIRECTION
  2. touch MovableCoord area VERTICALLY

then MovableCoord does fire release event.
@jongmoon jongmoon added this to the 1.3.0 milestone Jul 12, 2016
@jongmoon jongmoon self-assigned this Jul 12, 2016
@jongmoon jongmoon changed the title MovableCoord - interrupt(locking) release bug MovableCoord - release bug Jul 12, 2016
jongmoon pushed a commit to jongmoon/egjs that referenced this issue Jul 12, 2016
fix(MovableCoord): fire release event
ed6ccb3 
fire release event when moved different direction that was set.

Ref naver#288
jongmoon pushed a commit to jongmoon/egjs that referenced this issue Jul 12, 2016
fix(MovableCoord): add exception for DIRECTION_NONE
18c6120 
Ref naver#288

skip:
@jongmoon jongmoon mentioned this issue Jul 12, 2016
Merged
This was referenced Aug 22, 2016
Merged
Merged
taihoon pushed a commit that referenced this issue Sep 20, 2016
chore(jsdoc): Apply SEO (#289)
13e6ef5 
Close #288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongmoon jongmoon

Labels
bug movableCoord
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@jongmoon