Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency agent in rotate #357

Closed
sculove opened this issue Aug 11, 2016 · 1 comment
Closed

remove dependency agent in rotate #357

sculove opened this issue Aug 11, 2016 · 1 comment
Assignees
@netil
Labels
enhancement rotate V2
Projects
v2
Milestone
1.4.0

Comments

@sculove
Copy link
Contributor

sculove commented Aug 11, 2016

Description

roate has eg.agent dependency.
eg.agent is so big.
we should remove dependency of eg.agent
@sculove sculove added the rotate label Aug 11, 2016
@sculove sculove added this to the 1.3.0 milestone Aug 11, 2016
@sculove sculove modified the milestone: 1.3.0 Aug 11, 2016
@mixed
Copy link
Member

mixed commented Sep 26, 2016

We have decided that each component did select inner / outer lib of dependency.

@netil netil self-assigned this Oct 27, 2016
@netil netil added this to the 1.4.0 milestone Oct 27, 2016
@mixed mixed modified the milestone: 1.4.0 Oct 27, 2016
@mixed mixed added the V2 label Nov 10, 2016
netil added a commit to netil/egjs that referenced this issue Nov 14, 2016
@netil
feat(rotate): Remove eg.agent dependency
58d5049 
Removed internal eg.agent() dependency, handling UA internally

Ref naver#357
@netil netil mentioned this issue Nov 14, 2016
Merged
@netil netil closed this as completed in b512aeb Nov 16, 2016
netil pushed a commit that referenced this issue Dec 15, 2016
fix(rotate): remove dependency agent in rotate
82cd9f5 
Fixed regex pattern to catch iPad
- Ref: #357

Fix #298
Close #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
enhancement rotate V2
Projects
No open projects
v2
DONE
Milestone
1.4.0
Development

No branches or pull requests
3 participants
@mixed @sculove @netil