Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option for checking #365

Closed
sculove opened this issue Aug 25, 2016 · 2 comments
Closed

add option for checking #365

sculove opened this issue Aug 25, 2016 · 2 comments
Assignees
@sculove @taihoon
Labels
enhancement visible
Milestone
1.4.0

Comments

@sculove
Copy link
Contributor

sculove commented Aug 25, 2016

Description

User needs to check whether item is inner or outside totally
@mixed mixed modified the milestone: 1.4.0 Oct 27, 2016
@taihoon taihoon self-assigned this Nov 4, 2016
@taihoon
Copy link

taihoon commented Nov 22, 2016 •
edited

@sculove
How about this? Let me know your idea.

Checks whether the visible of the target elements has changed. It trigger that change event on a component.
대상 엘리먼트의 가시성이 변경됐는지 체크한다. change 이벤트를 발생한다.

check([delay, containment])

  • delay
    • Type: Number
    • Delay time. It delay that change event trigger.
    • 지연시간. change 이벤트 발생을 지연한다.
  • containment
    • Type: Boolean
    • Whether to check only elements that are completely contained within the reference area.
    • 기준 영역 안에 완전히 포함된 엘리먼트만 체크할지 여부.

@sculove
Copy link
Contributor Author

sculove commented Nov 23, 2016

@kishu good job!

taihoon pushed a commit to taihoon/egjs that referenced this issue Nov 24, 2016
docs(visible): Improve description for argument 'containment'.
69c1af8 
Ref naver#365
taihoon pushed a commit to taihoon/egjs that referenced this issue Nov 24, 2016
feat(visible): Add init code for arg 'containment'.
5e0eb05 
Ref naver#365
taihoon pushed a commit to taihoon/egjs that referenced this issue Nov 24, 2016
feat(visible): Add the branch code of condition 'containment'.
7d644f6 
Ref naver#365
taihoon pushed a commit to taihoon/egjs that referenced this issue Nov 24, 2016
test(visible): Add test code for 'containment'.
c3170f9 
Ref naver#365
@taihoon taihoon mentioned this issue Nov 24, 2016
Merged
sculove pushed a commit that referenced this issue Nov 24, 2016
@sculove
feat(visible): check 'containment' elements (#421)
6039277 
* docs(visible): Improve description for argument 'containment'.
* feat(visible): Add init code for arg 'containment'.
* feat(visible): Add the branch code of condition  'containment'.
* test(visible): Add test code for  'containment'.

Ref #365
@sculove sculove closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculove sculove

@taihoon taihoon

Labels
enhancement visible
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
3 participants
@mixed @sculove @taihoon