We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should call unbind method within destroy method. To remove keyValue for hammer.js instance.
keyValue
Removing dependency of jQuery.fn.data also can be a solution.
jQuery.fn.data
this._hammers[keyValue]
https://github.com/naver/egjs/blob/master/src/movableCoord.js#L124
if (keyValue) { this._hammers[keyValue].inst.destroy(); } else { keyValue = Math.round(Math.random() * new Date().getTime()); }
The text was updated successfully, but these errors were encountered:
fix(MovableCoord): clean resource after destruction
e6c6125
ref naver#378
fix(MovableCoord): clean resource after destruction (#403)
9587d92
ref #378
sculove
No branches or pull requests
Description
Should call unbind method within destroy method.
To remove
keyValue
for hammer.js instance.Removing dependency of
jQuery.fn.data
also can be a solution.Steps to check or reproduce
this._hammers[keyValue]
is undefined but keyValue is still exists.https://github.com/naver/egjs/blob/master/src/movableCoord.js#L124
The text was updated successfully, but these errors were encountered: