eg.pauseResume - support pause/resume on $.fn.delay #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {Number} An integer indicating the number of milliseconds to delay execution of the next item in the queue. | ||
| * @param {String} A string containing the name of the queue. Defaults to fx, the standard effects queue. | ||
| */ | ||
| $.fn.delay = function(time, type) { |
There was a problem hiding this comment.
Suggest define third parameter explicitly with adding comment for internal use beside the parameter. Because number of additional parameter is not variable.
like below
$.fn.delay = function(time, type, /* Internal Use Only */ isCallByResume ) {
There was a problem hiding this comment.
@happyhj I agree it is more readable.My intension is to reduce confusion about third parameter because function interface is easily exposed. I'll consider more.. Is there any opinion @naver/egjs-dev ?
There was a problem hiding this comment.
I don't care. I like both ways
|
LGTM~! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#167
Details
Support pause/resume on $.fn.delay
Preferred reviewers
@happyhj, @naver/egjs-dev