Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rotate3d and fix interpolation bug on rotation. #180

Merged
merged 4 commits into from
Apr 21, 2016

Conversation

jongmoon
Copy link
Contributor

Issue

#166

Details

Support rotate3d and fix interpolation bug on rotation.

Preferred reviewers

@naver/egjs-dev

@jongmoon
Copy link
Contributor Author

By this refactoring, we can support FireFox!

}
}

function getTransformGenerateFunction(transform) {
function getTransformGenerateFunction(element, transform) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The element parameter is not used anywhere in the function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@happyhj Oh, thank you. Yes, it is needless code!

@happyhj
Copy link
Contributor

happyhj commented Apr 19, 2016

LGTM 👍

@jongmoon jongmoon merged commit 402b65b into naver:master Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants