feat(infiniteGrid): remove outlayer dependency #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and code refactoring ref #282
|
I add test case and use QUnit 2.0 style. |
| @@ -454,7 +254,7 @@ eg.module("infiniteGrid", ["jQuery", eg, window, document, "Outlayer"], function | |||
| * @return {Boolean} | |||
| */ | |||
| isRecycling: function() { | |||
| return this.core.options.count > 0 && this._isRecycling; | |||
| return (this.options.count > 0) && this._isRecycling; | |||
There was a problem hiding this comment.
This is same to isRecycling().
Overall, both of _isRecycling and isRecycling() called. I think only isRecyling() shuld used.
| _itemize: function(elements, groupKey, isAppend) { | ||
| var dummyTop = -this._clientHeight + "px"; | ||
| return elements.map(function(v) { | ||
| v.style.top = dummyTop; |
There was a problem hiding this comment.
v.style.top = -this._clientHeight + "px";
Remove dummyTop
There was a problem hiding this comment.
dummyTop is always same.
|
LGTM |
sculove
added a commit
that referenced
this pull request
Jul 29, 2016
... and code refactoring Close #282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#282
Details
remove outlayer dependency
concatbuild taskremove test file.I will send pr for testPreferred reviewers
@naver/egjs-dev