Fix collection generation not throw exception (#999)

naver · Jul 8, 2024 · 87b15b3 · 87b15b3
1 parent 2eaa787
commit 87b15b3
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/...ava/com/navercorp/fixturemonkey/api/introspector/SingleGenericCollectionIntrospector.java b/...ava/com/navercorp/fixturemonkey/api/introspector/SingleGenericCollectionIntrospector.java
@@ -60,7 +60,17 @@ public ArbitraryIntrospectorResult introspect(ArbitraryGeneratorContext context)
 		List<CombinableArbitrary<?>> elementCombinableArbitraryList = context.getElementCombinableArbitraryList();
 
 		Class<?> type = Types.getActualType(context.getResolvedType());
-		Constructor<?> declaredConstructor = TypeCache.getDeclaredConstructor(type, Collection.class);
+		Constructor<?> declaredConstructor;
+		try {
+			declaredConstructor = TypeCache.getDeclaredConstructor(type, Collection.class);
+		} catch (Exception ex) {
+			LOGGER.warn(
+				"The collection interface is not resolved by the ConcretePropertyCandidateResolver. Generated as null.",
+				ex
+			);
+			return ArbitraryIntrospectorResult.NOT_INTROSPECTED;
+		}
+
 		return new ArbitraryIntrospectorResult(
 			CombinableArbitrary.containerBuilder()
 				.elements(elementCombinableArbitraryList)

diff --git a/...onkey-tests/java-tests/src/test/java/com/navercorp/fixturemonkey/tests/java/JavaTest.java b/...onkey-tests/java-tests/src/test/java/com/navercorp/fixturemonkey/tests/java/JavaTest.java
@@ -29,6 +29,7 @@
 import java.lang.reflect.Modifier;
 import java.time.Instant;
 import java.util.Arrays;
+import java.util.Collection;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
@@ -1232,4 +1233,12 @@ void constant() {
 			() -> SUT.giveMeOne(ConstantObject.class)
 		);
 	}
+
+	@Test
+	void collectionNotThrows() {
+		thenNoException().isThrownBy(
+			() -> SUT.giveMeOne(new TypeReference<Collection<String>>() {
+			})
+		);
+	}
 }