Add ability to build docker images through mvn (via docker-maven-plugin) #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidmalina
force-pushed
the
docker-maven-plugin
branch
from
eec42f2
to
7f18aec
Compare
dawidmalina
force-pushed
the
docker-maven-plugin
branch
from
3ad3f34
to
5c3e9f9
Compare
|
To work properly (agent attached as docker volume) we need this change to be merged and released spotify/docker-maven-plugin#161 |
|
@dawidmalina thanks. We need more time to review and test this. |
|
LGTM!! but other guy is checking some other side-effects. |
koo-taejin
added a commit
that referenced
this pull request
Jan 11, 2016
Add ability to build docker images through mvn (via docker-maven-plugin)
dawidmalina
added a commit
to dawidmalina/pinpoint
that referenced
this pull request
Mar 20, 2016
… volumes support
nstopkimsk
added a commit
that referenced
this pull request
Mar 21, 2016
Follow-up #1378 bump docker-maven-plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can very easily build local changes as docker images
and run pinpoint dockerized via docker-compose
To make this happen I've added:
This approach may look weird at the beginning but it is very helpful during testing. Dockerizing is not bound into regular maven phase so will not expand build time unless someone run this
mvn docker:build