[#112] Deprecate pad array option #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate pad array option
Padding primitive type array such as
byte[]is not expected case as usual.I think it's a little more intuitive to deprecate whole array, rather than primitive type array.
So we deprecate
padArrayoptions.Primitive type array padding 은 보통 예상되는 행동이 아닙니다.
선별적인 것 보다 Array 인 경우에는 Padding 하지 않도록 변경하는 것이
조금 더 직관적이라 생각해서
Deprecated처리합니다.