Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure abstract base classes Positionable and Bounded #213

Closed
navispatial opened this issue Oct 9, 2023 · 1 comment
Closed

Restructure abstract base classes Positionable and Bounded #213

navispatial opened this issue Oct 9, 2023 · 1 comment
Labels
enhancement New feature or request 🌐 geobase Related to the code package "geobase" refactoring

Comments

@navispatial
Copy link
Member

Restructure abstract base classes Positionable and Bounded. Add also a new abstract base class ValuePositionable.

The aim is to make class APIs more consistent with as minor changes to concrete subtypes as possible.

After the change inheritance tree would be something like this:

  • Positionable
  • ValuePositionable extends Positionable
  • Bounded extends Positionable
  • Position extends ValuePositionable
  • Box extends ValuePositionable
  • PositionSeries extends ValuePositionable, Bounded
  • Geometry extends Bounded
  • FeatureObject extends Bounded
@navispatial navispatial added enhancement New feature or request refactoring 🌐 geobase Related to the code package "geobase" labels Oct 9, 2023
@navispatial navispatial mentioned this issue Oct 13, 2023
Closed
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): ValuePositionable between Positionable and positio…
b37cd6b 
…n primitive classes #213
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): coordType in Positionable and deprecate type in Va…
ab6a864 
…luePositionable #213
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): definitions of equalsCooords, equals2D and equals3…
cafe9e7 
…D to Positionable #213
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): definition of project to Positionable #213
52f2c9d
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): rename emptiness check methods in PositionSeries t…
2b64df8 
…o be consistent with Bounded #213
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): when bounded object is projected or geometry chang…
f570ca0 
…ed, then bounds is not recalculated by default #213
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): use position scheme when calculating bounds #213, #…
5bf0eae 
…214
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
feat(geobase): PositionSeries to extend Bounded #212 #213 #214
0d12fd6
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
feat(geobase): getBounds for Bounded #213
02186a7
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): geometry and feature classes using position series…
0396bb3 
… to merge bounding boxes #211 #213
navispatial added a commit that referenced this issue Oct 15, 2023
@navispatial
refactor(geobase): traverse in populated/unpopulated only for geometr…
3668072 
…y and feature objects #213
@navispatial navispatial mentioned this issue Oct 15, 2023
Closed
navispatial added a commit that referenced this issue Oct 22, 2023
@navispatial
refactor(geobase): define values, valuesByType, copyByType and toText…
ea7a6fe 
… in ValuePositionable #213
navispatial added a commit that referenced this issue Oct 22, 2023
@navispatial
feat(geobase): positionCount and valueCount in ValuePositionable #213
3f425ce
navispatial added a commit that referenced this issue Oct 27, 2023
@navispatial
fix(geobase): deprecate type in PositionSeries, use coordType #213
ae4631f
@navispatial
Copy link
Member Author

Implemented in geobase 1.0.0.

@navispatial navispatial mentioned this issue Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request 🌐 geobase Related to the code package "geobase" refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@navispatial