Skip to content

Commit

Permalink
Add migration to rebuild albums paths
Browse files Browse the repository at this point in the history
  • Loading branch information
deluan committed Feb 2, 2023
1 parent bcab3cc commit 3c5032a
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 1 deletion.
2 changes: 1 addition & 1 deletion db/migration/20230112111457_add_album_paths.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func upAddAlbumPathsDirs(filePaths string) string {
}
slices.Sort(dirs)
dirs = slices.Compact(dirs)
return strings.Join(dirs, consts.Zwsp)
return strings.Join(dirs, string(filepath.ListSeparator))
}

func downAddAlbumPaths(tx *sql.Tx) error {
Expand Down
62 changes: 62 additions & 0 deletions db/migration/20230202143713_change_path_list_separator.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package migrations

import (
"database/sql"
"path/filepath"
"strings"

"github.com/navidrome/navidrome/consts"
"github.com/navidrome/navidrome/log"
"github.com/pressly/goose"
"golang.org/x/exp/slices"
)

func init() {
goose.AddMigration(upChangePathListSeparator, downChangePathListSeparator)
}

func upChangePathListSeparator(tx *sql.Tx) error {
//nolint:gosec
rows, err := tx.Query(`
select album_id, group_concat(path, '` + consts.Zwsp + `') from media_file group by album_id
`)
if err != nil {
return err
}

stmt, err := tx.Prepare("update album set paths = ? where id = ?")
if err != nil {
return err
}

var id, filePaths string
for rows.Next() {
err = rows.Scan(&id, &filePaths)
if err != nil {
return err
}

paths := upChangePathListSeparatorDirs(filePaths)
_, err = stmt.Exec(paths, id)
if err != nil {
log.Error("Error updating album's paths", "paths", paths, "id", id, err)
}
}
return rows.Err()
}

func upChangePathListSeparatorDirs(filePaths string) string {
allPaths := strings.Split(filePaths, consts.Zwsp)
var dirs []string
for _, p := range allPaths {
dir, _ := filepath.Split(p)
dirs = append(dirs, filepath.Clean(dir))
}
slices.Sort(dirs)
dirs = slices.Compact(dirs)
return strings.Join(dirs, consts.Zwsp)
}

func downChangePathListSeparator(tx *sql.Tx) error {
return nil
}

0 comments on commit 3c5032a

Please sign in to comment.