Skip to content

Commit

Permalink
WIP: Add to playlist
Browse files Browse the repository at this point in the history
  • Loading branch information
deluan committed May 16, 2020
1 parent 5a42fdf commit 99ea191
Show file tree
Hide file tree
Showing 11 changed files with 225 additions and 25 deletions.
15 changes: 9 additions & 6 deletions model/playlist.go
Expand Up @@ -19,25 +19,28 @@ type Playlist struct {
UpdatedAt time.Time `json:"updatedAt"`
}

type Playlists []Playlist

type PlaylistRepository interface {
CountAll(options ...QueryOptions) (int64, error)
Exists(id string) (bool, error)
Put(pls *Playlist) error
Get(id string) (*Playlist, error)
GetAll(options ...QueryOptions) (Playlists, error)
Delete(id string) error
Tracks(playlistId string) PlaylistTracksRepository
Tracks(playlistId string) PlaylistTrackRepository
}

type PlaylistTracks struct {
type PlaylistTrack struct {
ID string `json:"id" orm:"column(id)"`
MediaFileID string `json:"mediaFileId" orm:"column(media_file_id)"`
PlaylistID string `json:"playlistId" orm:"column(playlist_id)"`
MediaFile
}

type PlaylistTracksRepository interface {
type PlaylistTracks []PlaylistTrack

type PlaylistTrackRepository interface {
rest.Repository
//rest.Persistable
Add(mediaFileIds []string) (PlaylistTracks, error)
}

type Playlists []Playlist
2 changes: 1 addition & 1 deletion persistence/playlist_repository.go
Expand Up @@ -72,7 +72,7 @@ func (r *playlistRepository) Get(id string) (*model.Playlist, error) {

func (r *playlistRepository) GetAll(options ...model.QueryOptions) (model.Playlists, error) {
sel := r.newSelect(options...).Columns("*")
var res model.Playlists
res := model.Playlists{}
err := r.queryAll(sel, &res)
return res, err
}
Expand Down
Expand Up @@ -2,18 +2,19 @@ package persistence

import (
. "github.com/Masterminds/squirrel"
"github.com/deluan/navidrome/log"
"github.com/deluan/navidrome/model"
"github.com/deluan/rest"
)

type playlistTracksRepository struct {
type playlistTrackRepository struct {
sqlRepository
sqlRestful
playlistId string
}

func (r *playlistRepository) Tracks(playlistId string) model.PlaylistTracksRepository {
p := &playlistTracksRepository{}
func (r *playlistRepository) Tracks(playlistId string) model.PlaylistTrackRepository {
p := &playlistTrackRepository{}
p.playlistId = playlistId
p.ctx = r.ctx
p.ormer = r.ormer
Expand All @@ -24,11 +25,11 @@ func (r *playlistRepository) Tracks(playlistId string) model.PlaylistTracksRepos
return p
}

func (r *playlistTracksRepository) Count(options ...rest.QueryOptions) (int64, error) {
func (r *playlistTrackRepository) Count(options ...rest.QueryOptions) (int64, error) {
return r.count(Select().Where(Eq{"playlist_id": r.playlistId}), r.parseRestOptions(options...))
}

func (r *playlistTracksRepository) Read(id string) (interface{}, error) {
func (r *playlistTrackRepository) Read(id string) (interface{}, error) {
sel := r.newSelect().
LeftJoin("annotation on ("+
"annotation.item_id = media_file_id"+
Expand All @@ -37,12 +38,12 @@ func (r *playlistTracksRepository) Read(id string) (interface{}, error) {
Columns("starred", "starred_at", "play_count", "play_date", "rating", "f.*", "playlist_tracks.*").
Join("media_file f on f.id = media_file_id").
Where(And{Eq{"playlist_id": r.playlistId}, Eq{"id": id}})
var trk model.PlaylistTracks
var trk model.PlaylistTrack
err := r.queryOne(sel, &trk)
return &trk, err
}

func (r *playlistTracksRepository) ReadAll(options ...rest.QueryOptions) (interface{}, error) {
func (r *playlistTrackRepository) ReadAll(options ...rest.QueryOptions) (interface{}, error) {
sel := r.newSelect(r.parseRestOptions(options...)).
LeftJoin("annotation on ("+
"annotation.item_id = media_file_id"+
Expand All @@ -51,18 +52,23 @@ func (r *playlistTracksRepository) ReadAll(options ...rest.QueryOptions) (interf
Columns("starred", "starred_at", "play_count", "play_date", "rating", "f.*", "playlist_tracks.*").
Join("media_file f on f.id = media_file_id").
Where(Eq{"playlist_id": r.playlistId})
var res []model.PlaylistTracks
res := model.PlaylistTracks{}
err := r.queryAll(sel, &res)
return res, err
}

func (r *playlistTracksRepository) EntityName() string {
func (r *playlistTrackRepository) EntityName() string {
return "playlist_tracks"
}

func (r *playlistTracksRepository) NewInstance() interface{} {
return &model.PlaylistTracks{}
func (r *playlistTrackRepository) NewInstance() interface{} {
return &model.PlaylistTrack{}
}

var _ model.PlaylistTracksRepository = (*playlistTracksRepository)(nil)
var _ model.ResourceRepository = (*playlistTracksRepository)(nil)
func (r *playlistTrackRepository) Add(mediaFileIds []string) (model.PlaylistTracks, error) {
log.Debug(r.ctx, "Adding songs to playlist", "playlistId", r.playlistId, "mediaFileIds", mediaFileIds)
return nil, nil
}

var _ model.PlaylistTrackRepository = (*playlistTrackRepository)(nil)
var _ model.ResourceRepository = (*playlistTrackRepository)(nil)
7 changes: 5 additions & 2 deletions server/app/app.go
Expand Up @@ -51,7 +51,7 @@ func (app *Router) routes(path string) http.Handler {
app.R(r, "/transcoding", model.Transcoding{}, conf.Server.EnableTranscodingConfig)
app.RX(r, "/translation", newTranslationRepository, false)

app.addPlaylistTracksRoute(r)
app.addPlaylistTrackRoute(r)

// Keepalive endpoint to be used to keep the session valid (ex: while playing songs)
r.Get("/keepalive/*", func(w http.ResponseWriter, r *http.Request) { _, _ = w.Write([]byte(`{"response":"ok"}`)) })
Expand Down Expand Up @@ -90,7 +90,7 @@ func (app *Router) RX(r chi.Router, pathPrefix string, constructor rest.Reposito

type restHandler = func(rest.RepositoryConstructor, ...rest.Logger) http.HandlerFunc

func (app *Router) addPlaylistTracksRoute(r chi.Router) {
func (app *Router) addPlaylistTrackRoute(r chi.Router) {
// Add a middleware to capture the playlisId
wrapper := func(f restHandler) http.HandlerFunc {
return func(res http.ResponseWriter, req *http.Request) {
Expand All @@ -110,6 +110,9 @@ func (app *Router) addPlaylistTracksRoute(r chi.Router) {
r.Use(UrlParams)
r.Get("/", wrapper(rest.Get))
})
r.With(UrlParams).Post("/", func(w http.ResponseWriter, r *http.Request) {
addToPlaylist(app.ds)(w, r)
})
})
}

Expand Down
38 changes: 38 additions & 0 deletions server/app/playlists.go
@@ -0,0 +1,38 @@
package app

import (
"encoding/json"
"fmt"
"net/http"

"github.com/deluan/navidrome/model"
"github.com/deluan/navidrome/utils"
)

type addTracksPayload struct {
Ids []string `json:"ids"`
}

func addToPlaylist(ds model.DataStore) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
playlistId := utils.ParamString(r, ":playlistId")
tracksRepo := ds.Playlist(r.Context()).Tracks(playlistId)
var payload addTracksPayload
err := json.NewDecoder(r.Body).Decode(&payload)
if err != nil {
http.Error(w, err.Error(), http.StatusBadRequest)
return
}
_, err = tracksRepo.Add(payload.Ids)
if err != nil {
http.Error(w, err.Error(), http.StatusBadRequest)
return
}

// Must return an object with an ID, to satisfy ReactAdmin `create` call
_, err = w.Write([]byte(fmt.Sprintf(`{"id":"%s"}`, playlistId)))
if err != nil {
http.Error(w, err.Error(), http.StatusBadRequest)
}
}
}
77 changes: 77 additions & 0 deletions ui/src/common/SelectPlaylistDialog.js
@@ -0,0 +1,77 @@
import React from 'react'
import PropTypes from 'prop-types'
import { useGetList, useTranslate } from 'react-admin'
import { makeStyles } from '@material-ui/core/styles'
import Avatar from '@material-ui/core/Avatar'
import List from '@material-ui/core/List'
import ListItem from '@material-ui/core/ListItem'
import ListItemAvatar from '@material-ui/core/ListItemAvatar'
import ListItemText from '@material-ui/core/ListItemText'
import DialogTitle from '@material-ui/core/DialogTitle'
import Dialog from '@material-ui/core/Dialog'
import { blue } from '@material-ui/core/colors'
import PlaylistIcon from '../icons/Playlist'

const useStyles = makeStyles({
avatar: {
backgroundColor: blue[100],
color: blue[600],
},
})

function SelectPlaylistDialog(props) {
const classes = useStyles()
const translate = useTranslate()
const { onClose, selectedValue, open } = props
const { ids, data, loaded } = useGetList(
'playlist',
{ page: 1, perPage: -1 },
{ field: '', order: '' },
{}
)

if (!loaded) {
return <div />
}

const handleClose = () => {
onClose(selectedValue)
}

const handleListItemClick = (value) => {
onClose(value)
}

return (
<Dialog
onClose={handleClose}
aria-labelledby="select-playlist-dialog-title"
open={open}
scroll={'paper'}
>
<DialogTitle id="select-playlist-dialog-title">
{translate('resources.playlist.actions.selectPlaylist')}
</DialogTitle>
<List>
{ids.map((id) => (
<ListItem button onClick={() => handleListItemClick(id)} key={id}>
<ListItemAvatar>
<Avatar className={classes.avatar}>
<PlaylistIcon />
</Avatar>
</ListItemAvatar>
<ListItemText primary={data[id].name} />
</ListItem>
))}
</List>
</Dialog>
)
}

SelectPlaylistDialog.propTypes = {
onClose: PropTypes.func.isRequired,
open: PropTypes.bool.isRequired,
selectedValue: PropTypes.string.isRequired,
}

export default SelectPlaylistDialog
2 changes: 2 additions & 0 deletions ui/src/common/index.js
Expand Up @@ -11,6 +11,7 @@ import SizeField from './SizeField'
import DocLink from './DocLink'
import List from './List'
import SongDatagridRow from './SongDatagridRow'
import SelectPlaylistDialog from './SelectPlaylistDialog'

export {
Title,
Expand All @@ -28,4 +29,5 @@ export {
formatRange,
ArtistLinkField,
artistLink,
SelectPlaylistDialog,
}
4 changes: 4 additions & 0 deletions ui/src/i18n/en.json
Expand Up @@ -22,6 +22,7 @@
},
"actions": {
"addToQueue": "Play Later",
"addToPlaylist": "Add to Playlist",
"playNow": "Play Now"
}
},
Expand Down Expand Up @@ -63,6 +64,9 @@
"public": "Public",
"updatedAt":"Updated at",
"createdAt": "Created at"
},
"actions": {
"selectPlaylist": "Add songs to playlist:"
}
},
"user": {
Expand Down
10 changes: 7 additions & 3 deletions ui/src/playlist/PlaylistSongs.js
Expand Up @@ -54,13 +54,17 @@ const PlaylistSongs = (props) => {
const isXsmall = useMediaQuery((theme) => theme.breakpoints.down('xs'))
// const isDesktop = useMediaQuery((theme) => theme.breakpoints.up('md'))
const controllerProps = useListController(props)
const { bulkActionButtons, expand, className } = props
const { data, ids, version } = controllerProps
const { bulkActionButtons, expand, className, playlistId } = props
const { data, ids, version, loaded } = controllerProps

const anySong = data[ids[0]]
const showPlaceholder = !anySong
const showPlaceholder = !anySong || anySong.playlistId !== playlistId
const hasBulkActions = props.bulkActionButtons !== false

if (loaded && ids.length === 0) {
return <div />
}

return (
<>
<ListToolbar
Expand Down
61 changes: 61 additions & 0 deletions ui/src/song/AddToPlaylistButton.js
@@ -0,0 +1,61 @@
import React, { useState } from 'react'
import {
Button,
useTranslate,
useUnselectAll,
useDataProvider,
useNotify,
} from 'react-admin'
import SelectPlaylistDialog from '../common/SelectPlaylistDialog'
import PlaylistAddIcon from '@material-ui/icons/PlaylistAdd'

const AddToPlaylistButton = ({ resource, selectedIds }) => {
const [open, setOpen] = useState(false)
const [selectedValue, setSelectedValue] = useState('')
const translate = useTranslate()
const unselectAll = useUnselectAll()
const notify = useNotify()
const dataProvider = useDataProvider()

const handleClickOpen = () => {
setOpen(true)
}

const handleClose = (value) => {
if (value !== '') {
dataProvider
.create('playlistTrack', {
data: { ids: selectedIds },
filter: { playlist_id: value },
})
.then(() => {
notify(`Added ${selectedIds.length} songs to playlist`)
})
.catch(() => {
notify('ra.page.error', 'warning')
})
}
setOpen(false)
setSelectedValue(value)
unselectAll(resource)
}

return (
<>
<Button
color="secondary"
onClick={handleClickOpen}
label={translate('resources.song.actions.addToPlaylist')}
>
<PlaylistAddIcon />
</Button>
<SelectPlaylistDialog
selectedValue={selectedValue}
open={open}
onClose={handleClose}
/>
</>
)
}

export default AddToPlaylistButton
2 changes: 2 additions & 0 deletions ui/src/song/SongBulkActions.js
@@ -1,10 +1,12 @@
import React, { Fragment } from 'react'
import AddToQueueButton from './AddToQueueButton'
import AddToPlaylistButton from './AddToPlaylistButton'

export const SongBulkActions = (props) => {
return (
<Fragment>
<AddToQueueButton {...props} />
<AddToPlaylistButton {...props} />
</Fragment>
)
}

0 comments on commit 99ea191

Please sign in to comment.